SourceGenerators: assert diagnostic catalog consistency against AnalyzerReleases - #319
Merged
Merged
Conversation
Enforce DiagnosticIds, descriptors, and AnalyzerReleases markdown stay in lockstep so new DP### rules cannot drift across registration surfaces. Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
Build CatalogById with GroupBy so duplicate DP### registrations fail the dedicated uniqueness assertion with a listed diff, not ArgumentException. Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add reflection-based tests that keep
DiagnosticIds,DesignPatternsDiagnosticDescriptors, and AnalyzerReleases markdown rows in lockstep so newDP###rules cannot drift across registration surfaces.Claim note: Issue label/assignee updates returned HTTP 403 for this agent token. This open PR is the concurrency claim for #318 (do not rely on
agent-working).Related Issue
Closes #318
Solution module
DesignPatterns/)DesignPatterns.Diagnostics/)DesignPatterns.SourceGenerators/)DesignPatterns.Analyzers/+DesignPatterns.CodeFixes/)DesignPatterns.Extensions.DependencyInjection/)DesignPatterns.Package/)docs/,.github/,AGENTS.md,build/)Type of change
Test plan
./build.ps1 --target Ci --configuration Release(orCiPackif packaging changed)./build.ps1 --target CiBreaking changes
Checklist
CURSOR_SUMMARY, "Made with …")Documentation checklist
Changes
DiagnosticCatalogConsistencyTestscovering per-id Category/Severity/HelpLink/message checks and set-level id/descriptor/markdown consistency